Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include polyfills in jasmine-requirejs.html; include original (full) stack trace in onError output #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

raffishquartan
Copy link

This PR is for two minor issues I had using this template with grunt-contrib-jasmine. Some simple one line changes:

  • The template now loads polyfills as part of its require (e.g. es5-shim)
  • The error output did not include the full stack trace

Thanks!

@lukeapage lukeapage mentioned this pull request Apr 10, 2015
@purtuga
Copy link

purtuga commented Apr 11, 2015

+1 for this. Spent 2h chasing this issues last week.

@andrewshawcare
Copy link

+1

1 similar comment
@tessat
Copy link

tessat commented Jul 13, 2015

+1

@killtheliterate
Copy link

Heh, +1 didn't look here before making #85

@talon
Copy link

talon commented Sep 4, 2015

This PR adds the polyfills after the vendors. I'd argue in favor of #85 as it adds polyfills before any other JS, which is preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants