Skip to content
This repository has been archived by the owner on Nov 5, 2022. It is now read-only.

[JENKINS-34064] Groovy 2.x fixes #51

Closed
wants to merge 20 commits into from

Commits on Apr 6, 2016

  1. Configuration menu
    Copy the full SHA
    ae43475 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2016

  1. Configuration menu
    Copy the full SHA
    1c07ff4 View commit details
    Browse the repository at this point in the history
  2. patch() is supposed to almost act idempotently

    so returning the same type makes the patching code above easier
    kohsuke committed May 19, 2016
    Configuration menu
    Copy the full SHA
    640f013 View commit details
    Browse the repository at this point in the history
  3. Groovy 2.x changed the signature of ClassInfo.globalClassSet

    ... that we need to rewrite differently.
    kohsuke committed May 19, 2016
    Configuration menu
    Copy the full SHA
    e660e30 View commit details
    Browse the repository at this point in the history
  4. Aiding overload resolution

    While running tests, I came across a strange test failure where
    each(List,Closure) is delegating to each(Iterator,Closure) and results
    in a cast failure. Obviously, it shuold have resolved to
    each(Object,Closure) instead.
    
    This got me thinking about how Groovy resolves overloaded methods, which
    is non-trivial as a dynamic language.
    
    So in this change I'm changing the code so that Groovy doesn't have to
    resolve overloaded versions correctly.
    kohsuke committed May 19, 2016
    Configuration menu
    Copy the full SHA
    234faeb View commit details
    Browse the repository at this point in the history
  5. The problem in the previous commit was due to the return type!

    The correct signature, which you can check in DefaultGroovyMethods, is
    to return the 'self' type
    kohsuke committed May 19, 2016
    Configuration menu
    Copy the full SHA
    fc5b7be View commit details
    Browse the repository at this point in the history

Commits on May 31, 2016

  1. Making it clearer from a test failure that we are running the block, …

    …if only once, rather than merely returning the list element.
    jglick committed May 31, 2016
    Configuration menu
    Copy the full SHA
    f248a0f View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2016

  1. [JENKINS-34064] Added a test to warm up Groovy runtime

    The suspected cause of the problem is that DGMPatcher is not touching
    everything it needs to touch, when Groovy runtime is already warm and
    cached lots of MetaMethod objects.
    
    This test, having a name that is alphabetically before
    CpsTransformerTest, runs before that and populates the cache, exposing
    the defect in DGMPatcher.
    
    Run the test like this:
    
      mvn clean test -Dtest=AaaMakeGroovyBusy,CpsTransformerTest
    kohsuke committed Jun 27, 2016
    Configuration menu
    Copy the full SHA
    a362d88 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5012f04 View commit details
    Browse the repository at this point in the history
  3. Better traversal of Set; calling remove(Object) could incorrectly tre…

    …at elements overriding Object.equals.
    jglick committed Jun 27, 2016
    Configuration menu
    Copy the full SHA
    5cd4abb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    57720f7 View commit details
    Browse the repository at this point in the history
  5. Remember which objects we traversed

    ... and cast wider net to traverse a bigger graph
    kohsuke committed Jun 27, 2016
    Configuration menu
    Copy the full SHA
    0e27ded View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2016

  1. Configuration menu
    Copy the full SHA
    6ccbdb3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a8b8e51 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2dda9e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2016

  1. Merge remote-tracking branch 'origin/DGMPatcher-Groovy-2-JENKINS-3406…

    …4' into DGMPatcher-Groovy-2-JENKINS-34064
    
    Conflicts:
    	src/main/java/com/cloudbees/groovy/cps/impl/DGMPatcher.java
    kohsuke committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    ba19abb View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2016

  1. Configuration menu
    Copy the full SHA
    7fa8551 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into DGMPatcher-Groovy-2-JENKINS-34064

    Reverting cloudbees#38 in this branch.
    jglick committed Aug 9, 2016
    Configuration menu
    Copy the full SHA
    68bc735 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2017

  1. Merge remote-tracking branch 'origin/master' into jenkins-34064-conti…

    …nued
    
    Conflicts:
    	src/test/groovy/com/cloudbees/groovy/cps/CpsTransformerTest.groovy
    abayer committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    1ee0805 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2017

  1. Configuration menu
    Copy the full SHA
    0800cbc View commit details
    Browse the repository at this point in the history