Add a metadata resource for instances #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a github registration endpoint that instances can use to fetch a github registration token. This change also invalidates disables access to an instance to the token and status updates endpoints once the instance transitions from "pending" or "installing" to any other state.
Define a metadata subrouter and move the token endpoint there. We may end up needing multiple endpoints for various purposes in the future. Signed-off-by: Gabriel Adrian Samfira <[email protected]>
Signed-off-by: Gabriel Adrian Samfira <[email protected]>
gabriel-samfira
changed the title
Signed-off-by: Gabriel Adrian Samfira <[email protected]>
Signed-off-by: Gabriel Adrian Samfira <[email protected]>
Signed-off-by: Gabriel Adrian Samfira <[email protected]>
Signed-off-by: Gabriel Adrian Samfira <[email protected]>
Signed-off-by: Gabriel Adrian Samfira <[email protected]>
gabriel-samfira
changed the title
Signed-off-by: Gabriel Adrian Samfira <[email protected]>
* Add logging middleware * Remove some noise from logs * Add some safety checks when managing runners
|
An additional safeguard was added to limit the number of tokens that can be requested by a bearer token belonging to a particular instance. If an instance token has fetched a github runner registration token, any subsequent attempt to fetch another runner token will fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, garm leverages the user data feature of providers to create runners and set them up. Storing the runner registration token may be a security vulnerability in some situations (see #48). This PR adds a new API endpoint that can be used by instances to retrieve a github runner registration token.
This new endpoint uses the same authentication middleware as the status update endpoint used by the instances to call home and report their state. The authentication middleware has also been changed to only allow access to instances that are in the
pendingorinstallingstate. once the instance transitions to any other state (installed,failed, etc), the instance can no longer access the two resources.