feat: Deployment options. Use pre-built package by default. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baolsen
force-pushed
the
feat-local-build
branch
4 times, most recently
from
2fcff34 to
6156c71
Compare
baolsen
commented
Feb 9, 2023
| # Include main requirements | ||
| -r ../costnotifier/requirements.txt | ||
|
|
||
| # Additional packages to install when doing testing |
There was a problem hiding this comment.
One nice thing with this change.
Only install boto3 when doing tests. It is already available within the lambda environment :D
baolsen
commented
Feb 9, 2023
| @@ -36,16 +57,21 @@ module "billing_notifier_lambda" { | |||
| function_name = var.naming_prefix | |||
| description = var.lambda_description | |||
|
|
|||
| handler = "handler.report_cost" | |||
| handler = "app.lambda_handler" | |||
| runtime = var.runtime | |||
| timeout = 300 | |||
|
|
|||
There was a problem hiding this comment.
Removing this means we no longer depend on the remote build environment
baolsen
force-pushed
the
feat-local-build
branch
2 times, most recently
from
a988d73 to
df0356f
Compare
|
I'll also do some testing in TF in our internal environments to check the lambda is still working :) |
baolsen
force-pushed
the
feat-local-build
branch
from
df0356f to
c61a4f3
Compare
baolsen
force-pushed
the
feat-local-build
branch
from
c61a4f3 to
1ad57a3
Compare
grasshopper-josh
approved these changes
Feb 9, 2023
|
Tagged with 0.42.0 for testing and rolled to our root account |
|
Tests passed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.