main, block: Remove device.reset() #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to reset the device as Cloud Hypervisor supports device reset itself (so the booted kernel will correctly reset the device on boot.) In particular resetting the block device prior to booting via EFI breaks the EFI boot. Fixes: cloud-hypervisor#35 Signed-off-by: Rob Bradford <[email protected]>
|
I've tested this with Cloud Hypervisor (bzImage and EFI) and QEMU (bzImage and EFI.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to reset the device as Cloud Hypervisor supports device
reset itself (so the booted kernel will correctly reset the device on
boot.)
In particular resetting the block device prior to booting via EFI breaks
the EFI boot.
Fixes: #35
Signed-off-by: Rob Bradford [email protected]