Update toolchain, improve linker script, and reduce binary size. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current toolchain is 5 months old, and we want a new toolcahin for: - "efiapi" ABI - Using `Self` with enum implementations - Misc cargo improvements Signed-off-by: Joe Richey <[email protected]>
This also gets rid of some warnings Signed-off-by: Joe Richey <[email protected]>
- &Trait -> &dyn Trait - Remove unneeded parens Signed-off-by: Joe Richey <[email protected]>
- Move image fetching out of main script - Move installation actions to "install" - Set warning configs via environment variables - Reorder sections to increase readablity Signed-off-by: Joe Richey <[email protected]>
- Makes the binary smaller - Prevents size regression when updating to new toolchain - Avoids bugs like: rust-lang/rust#62785 Signed-off-by: Joe Richey <[email protected]>
To allow for future flat BIOS builds, we reorder the sections to put the .text at the end (as that will contain the reset vector). We also remove the alignment requirements for the sections, as they are not necessary. This makes the binary about 10% smaller. Signed-off-by: Joe Richey <[email protected]>
This maps the file headers into readonly data, while preventing any
other sections from being generated. It also makes the file 8% smaller.
We also replace the marker symbols for {begin|end}_of_{text|data} with
symbols denoting the begining/end of the file itself.
Finally, we make an explict DISCARD section (based off of EDK2's
GccBase.lds to prevent any additional data from entering our binary).
Signed-off-by: Joe Richey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nightly-2019-11-05installsectionALIGNDISCARDsection, based on EDK2'sGccBase.lds.textlast (will help with Support building as flat BIOS image #5)cargo xbuild --release --target target.json)108256bytes59272bytesSee the individual commits for more details (be sure to "merge/rebase" not "squash").
Signed-off-by: Joe Richey [email protected]