fat: Fix incomplete comparing in compare_name and compare_short_name #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. Please commit using |
compare_name and compare_short_name compare incompletely if the argument "name" is shorter than a name of directory entries. This causes a failure to load EFI as reported in cloud-hypervisor#164 Fixes:cloud-hypervisor#164 Signed-off-by: Yuji Hagiwara <[email protected]>
default_entry_file() returns only the basename but it doesn't return the extension. this becomes problematic after compare_name() compare names' length too to fix cloud-hypervisor#164. default_entry_file() seems to assume that the extension of the file is ".conf". Signed-off-by: Yuji Hagiwara <[email protected]>
yuuzi41
force-pushed
the
fat_compare_name
branch
from
a6783e6 to
2e7e87b
Compare
|
Thank you for your suggestion. |
retrage
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compare_name function and compare_short_name function compare incompletely if the argument "name" is shorter than a name of directory entries.
This causes a failure to load EFI as reported in #164
Signed-off-by: Yuji Hagiwara [email protected]