Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws broker tag log groups perm #1813

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Add aws broker tag log groups perm #1813

merged 2 commits into from
Dec 20, 2024

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Dec 20, 2024 •
edited
Loading

Changes proposed in this pull request:

Related to cloud-gov/opensearch-boshrelease#144

  • Add permissions to allow tagging of cloudwatch log groups associated with brokered resources. This allows us to write a script in the aws-broker that keeps the tags in sync between databases and their log groups (see Reconcile log groups aws-broker#397), in turn making sure that logs are ingested with the proper metadata into OpenSearch

security considerations

We are adding a new permission but TagResource is non-destructive and constrained to a limited set of resources

@markdboyd markdboyd requested a review from a team as a code owner December 20, 2024 20:08
@markdboyd markdboyd enabled auto-merge (squash) December 20, 2024 20:13
@markdboyd markdboyd merged commit 9a43c7d into main Dec 20, 2024
4 checks passed
@markdboyd markdboyd deleted the add-aws-broker-tag-log-groups-perm branch December 20, 2024 20:13
@markdboyd markdboyd mentioned this pull request Dec 20, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweibel cweibel cweibel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdboyd @cweibel