Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconcile dependencies #4678

Merged
merged 1 commit into from
Nov 22, 2024
Merged

reconcile dependencies #4678

merged 1 commit into from
Nov 22, 2024

Conversation

drewbo
Copy link
Contributor

@drewbo drewbo commented Nov 22, 2024 •
edited
Loading

Changes proposed in this pull request:

  • removes unused dependencies
  • ensures used dependencies are included in package.json
  • move things between standard and dev dependencies as required

security considerations

None

@drewbo drewbo force-pushed the chore-reconcile-dependencies branch from 2657a2c to dc7383a Compare November 22, 2024 14:49
@drewbo
Copy link
Contributor Author

drewbo commented Nov 22, 2024

This was mostly for code clarity but also reduced the dev bundle size from 293kb to 290kb (gzipped)

@drewbo drewbo force-pushed the chore-reconcile-dependencies branch from dc7383a to 9e6f7c1 Compare November 22, 2024 16:24
@drewbo drewbo force-pushed the chore-reconcile-dependencies branch from 9e6f7c1 to 2f7b0cf Compare November 22, 2024 16:37
@cloud-gov-pages-operations
Copy link
Contributor

🤖 This is an automated code coverage report

Total coverage (lines): 14.56%
Coverage diff: 0% 📈

@drewbo drewbo requested a review from a team November 22, 2024 17:20
@drewbo drewbo merged commit 8706595 into main Nov 22, 2024
8 checks passed
@drewbo drewbo deleted the chore-reconcile-dependencies branch November 22, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apburnes apburnes apburnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drewbo @cloud-gov-pages-operations @apburnes