Upgrade to express 5 #4664
Merged
Upgrade to express 5 #4664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I used the checklist in #4611 (generated from the migration guide) to ensure we hit all the necessary items. A summary of the changes:
The new promise rejections should only be helpful, we might have a few unnecessary |
drewbo
force-pushed
the
chore-express-5
branch
from
f0670ec to
90f2de4
Compare
🤖 This is an automated code coverage reportTotal coverage (lines): 14.56% |
drewbo
force-pushed
the
chore-express-5
branch
4 times, most recently
from
eb1f13c to
58feead
Compare
apburnes
reviewed
Nov 20, 2024
api/routers/report.js
Outdated
| @@ -4,6 +4,6 @@ const MainController = require('../controllers/main'); | |||
| const { csrfProtection } = require('../middlewares'); | |||
|
|
|||
| // add csrf middleware to app route so that we can use request.csrfToken() | |||
| router.get('/report(/*)?', csrfProtection, MainController.report); | |||
| router.get('/report{*splat}', csrfProtection, MainController.report); | |||
There was a problem hiding this comment.
Should this be {/*splat} with the forward slash like the routes/main.js changes?
drewbo
force-pushed
the
chore-express-5
branch
from
58feead to
f4a5306
Compare
drewbo
force-pushed
the
chore-express-5
branch
from
f4a5306 to
f9f000e
Compare
apburnes
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
security considerations
Upgrading express should provide security upgrades by avoiding relying on outdated dependencies