Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-to-end test framework via playwright #4285

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

drewbo
Copy link
Contributor

@drewbo drewbo commented Nov 1, 2023

Changes proposed in this pull request:

  • A new job, e2e-test, is added to the dev CI pipeline.
  • This job creates a test user in the dev database, uses the associated token to run skeleton Playwright tests, removes the test user, then uploads the resulting test report to S3.

Notes

Possible improvements:

  • Adding this to staging
  • Making the test reports more discoverable

security considerations

CI creates (and removes) a test user with access to the dev database

@drewbo drewbo force-pushed the test-add-playwright branch 2 times, most recently from 4f3a011 to 8325a66 Compare November 6, 2023 18:12
@drewbo drewbo mentioned this pull request Nov 7, 2023
3 tasks
@drewbo drewbo force-pushed the test-add-playwright branch from 7154171 to 1329cee Compare November 7, 2023 19:04
@drewbo drewbo changed the title [WIP] Test add playwright Add end-to-end test framework via playwright Nov 7, 2023
@drewbo drewbo force-pushed the test-add-playwright branch from 70e1509 to 9a806c8 Compare November 8, 2023 16:20
@drewbo drewbo requested a review from a team November 8, 2023 16:21
Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome starting foundation!

ci/pipeline-dev.yml Show resolved Hide resolved
@drewbo drewbo force-pushed the test-add-playwright branch from 36212ca to 569fa57 Compare November 8, 2023 16:59
@drewbo drewbo requested a review from apburnes November 8, 2023 17:49
@drewbo drewbo merged commit f4cc567 into main Nov 8, 2023
3 checks passed
@drewbo drewbo deleted the test-add-playwright branch November 8, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants