Upgrade to AWS SDK v3 #4281
Merged
Upgrade to AWS SDK v3 #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenaas
force-pushed
the
3989-upgrade-to-aws-sdk-v3
branch
from
49cffe4 to
2e0e8be
Compare
drewbo
requested changes
Oct 26, 2023
api/services/S3Helper.js
Outdated
| } | ||
|
|
||
| listCommonPrefixes(prefix) { | ||
| async listCommonPrefixes(prefix) { |
There was a problem hiding this comment.
the three list/paginated functions could go back to using a helper function like before because they all have the same structure
There was a problem hiding this comment.
OK, this is pushed.
|
Next week when Drew and I are both here we should test this on dev — and subsequently on staging — to give the actual connection to S3 a shakedown. |
apburnes
reviewed
Oct 26, 2023
apburnes
previously approved these changes
Oct 30, 2023
drewbo
force-pushed
the
3989-upgrade-to-aws-sdk-v3
branch
from
330f19c to
4320c88
Compare
svenaas
force-pushed
the
3989-upgrade-to-aws-sdk-v3
branch
2 times, most recently
from
dbb0896 to
21bce64
Compare
drewbo
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Confirmed all of site creation/deletion, published files, and old build log fetching. There is one small error that I think we can push to a separate issue. If you click published files immediately after the site is created, it will still error but I think that can be handled separately in the front end
svenaas
force-pushed
the
3989-upgrade-to-aws-sdk-v3
branch
from
2a39267 to
3747620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3989
Changes proposed in this pull request:
aws-sdk-client-mockfor mocking AWS SDK callssecurity considerations
None. This is an update to an important dependency to keep us on a supported version.