-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make org/user data available via reports interface #4262
Conversation
dc042eb
to
e103e11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redeployed and tested on dev. Added another org to see multiple org users. Everything looks good. The only minor (optional) thing is I'd name the columns "Github email" and "UAA email" for consistency with the users view. Good to go once rebased
I agree with that. But the CSV export just has an "Email" (UAA) column for ZenDesk convenience as of this writing. Does that seem OK to you, @drewbo? |
e103e11
to
8d0f9f1
Compare
@drewbo, I changed the email column names and order in the users report to match the users administration page — that needs a re-review. But you can't just read that change because I also rebased this down to three discrete commits (you'd probably go with one, and I can do that if you prefer). |
Hold off on that, please; test is behaving differently in Concourse because I wasn't careful about ordering. Fixing that now. |
641a3e1
to
6c896e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the new report commits to feat(admin):
type? I'm not positive how the changelog will handle that but it better reflects those changes
6c896e6
to
b64e898
Compare
Yes. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last code piece I should have checked earlier: can you abstract the downloadCSV
function to accept the csv as input, and put this in a util file? (otherwise it's duplicated three times)
Yeah, sure (sigh) that's a good idea. I should have thought of that as I based two new Svelte files on the first one. |
b64e898
to
7c93682
Compare
OK, @drewbo, it's in |
Work to satisfy #4258, adding new reports with orgs and user/org/role information available as CSVs for import into ZenDesk. These reports are presented in the Admin UI as well (slightly differently), with the CSV downloads available from this interface, or potentially via direct calls to the API.
Changes proposed in this pull request:
/organizations-report
to/reports/published-sites
/reports/organizations
/reports/users
security considerations
None. The data presented is only available to authenticated admin/support users, and only represents data already available to those users.