Feat build task models #4245
Merged
Feat build task models #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbo
force-pushed
the
feat-build-task-models
branch
from
bef3075 to
4ca03be
Compare
drewbo
force-pushed
the
feat-build-task-models
branch
4 times, most recently
from
24e3573 to
c52bfc0
Compare
5 tasks
drewbo
force-pushed
the
feat-build-task-models
branch
from
c52bfc0 to
332c932
Compare
apburnes
requested changes
Sep 6, 2023
api/models/build-task.js
Outdated
| { | ||
| name: 'build_task_build_id_type_index', | ||
| unique: true, | ||
| fields: ['buildId'], |
There was a problem hiding this comment.
You need to add buildTaskTypeId based on the migration SQL.
There was a problem hiding this comment.
Excellent catch. My kingdom for not having to write these schemas twice
drewbo
force-pushed
the
feat-build-task-models
branch
from
332c932 to
2605ebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
security considerations
None