Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RTL test to @shared/GithubBuildBranchLink.jsx #4670

Closed
3 tasks done
Tracked by #4014
apburnes opened this issue Nov 20, 2024 · 0 comments · Fixed by #4689
Closed
3 tasks done
Tracked by #4014

Add RTL test to @shared/GithubBuildBranchLink.jsx #4670

apburnes opened this issue Nov 20, 2024 · 0 comments · Fixed by #4689
Assignees
@apburnes @sknep
Labels
squad-pages

Comments

@apburnes
Copy link
Contributor

apburnes commented Nov 20, 2024 •
edited by sknep
Loading

Add a test to @shared/GithubBuildBranchLink.jsx using the RTL framework. See our docs for writing frontend tests.

Acceptance Criteria

  • Colocate test file to @shared/GithubBuildBranchLink.test.jsx
  • Test the GitHubLink renders with the proper site owner, site repository, and build branch
  • Remove component defaultProps and add the to the component args
@apburnes apburnes mentioned this issue Dec 2, 2024
Open
@apburnes apburnes self-assigned this Dec 2, 2024
@sknep sknep self-assigned this Dec 5, 2024
sknep added a commit that referenced this issue Dec 5, 2024
@sknep
chore: Test shared/GithubBuildBranchLink #4670
1cf663a
@sknep sknep linked a pull request Dec 5, 2024 that will close this issue
Chore: test shared/GithubBuildBranchLink.jsx #4670 #4689
Merged
sknep added a commit that referenced this issue Dec 6, 2024
@sknep
chore: Test shared/GithubBuildBranchLink #4670
023e574
sknep added a commit that referenced this issue Dec 6, 2024
@sknep
chore: Test shared/GithubBuildBranchLink #4670
fb53cde
sknep added a commit that referenced this issue Dec 9, 2024
@sknep
chore: Test shared/GithubBuildBranchLink #4670
6c532a2
sknep added a commit that referenced this issue Dec 9, 2024
@sknep
chore: Test shared/GithubBuildBranchLink #4670
c530c9d
sknep added a commit that referenced this issue Dec 11, 2024
@sknep
chore: Test shared/GithubBuildBranchLink #4670
2cc3088
sknep added a commit that referenced this issue Dec 11, 2024
@sknep
chore: Test shared/GithubBuildBranchLink #4670
0045a6f
sknep added a commit that referenced this issue Dec 11, 2024
@sknep
Merge pull request #4689 from cloud-gov/chore-test-shared/GithubBuild…
59880f1 
…BranchLink-4670

Chore: test shared/GithubBuildBranchLink.jsx #4670
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apburnes apburnes

@sknep sknep

Labels
squad-pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: test shared/GithubBuildBranchLink.jsx #4670 cloud-gov/pages-core
2 participants
@apburnes @sknep