Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTL test to @shared/GithubBuildShaLink.jsx #4669

Closed
5 tasks done
Tracked by #4014
apburnes opened this issue Nov 20, 2024 · 0 comments · Fixed by #4688
Closed
5 tasks done
Tracked by #4014

Add RTL test to @shared/GithubBuildShaLink.jsx #4669

apburnes opened this issue Nov 20, 2024 · 0 comments · Fixed by #4688
Assignees

Comments

@apburnes
Copy link
Contributor

apburnes commented Nov 20, 2024

Add a test to @shared/GithubBuildShaLink.jsx using the RTL framework. See our docs for writing frontend tests.

Acceptance Criteria

  • Colocate test file to @shared/GithubBuildShaLink.test.jsx
  • Test the GithubLink component renders with the build.clonedCommitSha prop
  • Test the GithubLink component renders with the build.requestedCommitSha prop
  • Test nothing renders when the build.requestedCommitSha and build.clonedCommitSha are not available
  • Remove component defaultProps and add the to the component args
@apburnes apburnes self-assigned this Dec 2, 2024
@sknep sknep linked a pull request Dec 5, 2024 that will close this issue
@sknep sknep self-assigned this Dec 5, 2024
sknep added a commit that referenced this issue Dec 11, 2024
…ShaLink-4669

Chore: test shared/GitHubBuildShaLink #4669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants