Live and demo URL input focus is lost after first character is typed

[jseppi]

Steps to reproduce:

1. Click into a blank Live (or Demo) URL input box on the Site Settings page.
2. Type a character. The focus will jump to the Save Basic Settings button.

Expected behavior:
Focus remains in the input box while typing.

[jseppi]

It is due to code like this, which results in React re-rendering the component on change, which then makes the input lose focus (because it's actually a new DOM element):

component={p =>
  <HttpsUrlInput
    value={p.input.value}
    onChange={p.input.onChange}
    className="form-control"
    id="domainInput"
  />
}

This method was taken from the ReduxForm docs, but those examples are apparently wrong. More explanation at redux-form/redux-form#1094

[wslack]

Effort to fix?

[jseppi]

Fairly low effort. I’m thinking I could roll it in with fixing the weird error message when anything in the related form’s submission goes wrong. On Nov 22, 2017, at 12:41 PM, Will Slack <[email protected]> wrote: Effort to fix? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1307 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAql-NnOxa92_Y8imrCF0oCrfshy6thhks5s5GrZgaJpZM4Qnsy2> .

[wslack]

Makes sense, seems like we can put in "Ready" for you to pull off when wanted.