chore: upgrade to express 5 (#4611)

api/bull-board/config.js

@@ -85,6 +85,6 @@ module.exports = {
   rateSlowing: {
     windowMs: 1 * 60 * 1000, // 1 minute window
     delayAfter: 25, // delay requests by delayMs after 25 are made in a window
-    delayMs: 500, // delay requests by 500 ms
+    delayMs: () => 500, // delay requests by 500 ms
   },
 };

api/middlewares/parse-form.js

@@ -1,7 +1,6 @@
 const { urlencoded } = require('express');
 
 const parseForm = urlencoded({
-  extended: false,
   limit: '1kb',
 });
 

api/routers/build-log.js

@@ -2,10 +2,6 @@ const router = require('express').Router();
 const BuildLogController = require('../controllers/build-log');
 const { sessionAuth } = require('../middlewares');
 
-router.get(
-  '/build/:build_id/log(/offset/:offset)?',
-  sessionAuth,
-  BuildLogController.find,
-);
+router.get('/build/:build_id/log{/offset/:offset}', sessionAuth, BuildLogController.find);
 
 module.exports = router;

api/routers/build-task.js

@@ -17,6 +17,6 @@ router.post(
 router.put('/tasks/:build_task_id/:token', BuildTaskController.update);
 router.get('/tasks/types', sessionAuth, BuildTaskTypeController.list);
 router.get('/tasks/default-rules', sessionAuth, BuildTaskTypeController.getDefaultRules);
-router.get('/tasks/:task_id/report/:sub_page?', sessionAuth, BuildTaskController.report);
+router.get('/tasks/:task_id/report/{:sub_page}', sessionAuth, BuildTaskController.report);
 
 module.exports = router;

api/routers/main.js

@@ -7,12 +7,12 @@ router.get('/', MainController.home);
 router.get('/system-use', MainController.systemUse);
 
 // add csrf middleware to app route so that we can use request.csrfToken()
-router.get('/organizations(/*)?', csrfProtection, MainController.app);
-router.get('/sites(/*)?', csrfProtection, MainController.app);
+router.get('/organizations{/*splat}', csrfProtection, MainController.app);
+router.get('/sites{/*splat}', csrfProtection, MainController.app);
 router.get('/settings', csrfProtection, MainController.app);
 
 router.get('/robots.txt', MainController.robots);
 
-router.options('(/*)?', (_req, res) => res.notFound());
+router.options('{/*splat}', (_req, res) => res.notFound());
 
 module.exports = router;

api/routers/report.js

@@ -4,6 +4,6 @@ const MainController = require('../controllers/main');
 const { csrfProtection } = require('../middlewares');
 
 // add csrf middleware to app route so that we can use request.csrfToken()
-router.get('/report(/*)?', csrfProtection, MainController.report);
+router.get('/report{*splat}', csrfProtection, MainController.report);
 
 module.exports = router;

config/env/development.js

@@ -11,4 +11,7 @@ module.exports = {
   userEnvVar: {
     key: 'shhhhhhhhhhh',
   },
+  rateLimiting: {
+    skip: () => true,
+  }
 };

config/env/test.js

@@ -99,4 +99,12 @@ module.exports = {
   userEnvVar: {
     key: 'shhhhhhhhhhh',
   },
+  rateLimiting: {
+    skip: () => true,
+  },
+  rateSlowing: {
+    validate: {
+      delayMs: false
+    },
+  }
 };

config/rateLimiting.js

@@ -5,4 +5,7 @@
 */
 module.exports = {
   max: 0,
+  validate: {
+    trustProxy: false
+  },
 };

config/rateSlowing.js

@@ -5,5 +5,5 @@
 */
 module.exports = {
   delayAfter: 0,
-  delayMs: 0,
+  delayMs: () => 0,
 };

package.json

@@ -27,11 +27,11 @@
     "db-migrate-pg": "^1.5.2",
     "deep-extend": "^0.6",
     "eslint-plugin-react-hooks": "^4.6.0",
-    "express": "^4.19.2",
-    "express-rate-limit": "^5.2.3",
-    "express-session": "^1.18.0",
-    "express-slow-down": "^1.4.0",
-    "express-winston": "^4.0.5",
+    "express": "^5.0.1",
+    "express-rate-limit": "^7.4.1",
+    "express-session": "^1.18.1",
+    "express-slow-down": "^2.0.3",
+    "express-winston": "^4.2.0",
     "globals": "^15.12.0",
     "helmet": "^4.6.0",
     "inflection": "^1.13.1",
@@ -162,7 +162,7 @@
     "eslint-plugin-react": "^7.37.2",
     "eslint-plugin-sonarjs": "^2.0.4",
     "eslint-plugin-testing-library": "^6.4.0",
-    "fetch-mock": "^9.11.0",
+    "fetch-mock": "^12.1.0",
     "jest": "^29.6.2",
     "jest-environment-jsdom": "^29.6.2",
     "jsdom": "^23.0.1",
@@ -177,7 +177,6 @@
     "nodemon": "^3.0.1",
     "nyc": "^15.1.0",
     "playwright": "^1.42.1",
-    "plugin": "^0.3.3",
     "postcss": "^8.4.31",
     "postcss-loader": "^7.3.3",
     "prettier": "^3.3.3",