Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify use of Lets Encrypt #68

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Clarify use of Lets Encrypt #68

merged 1 commit into from
Dec 14, 2023

Conversation

pburkholder
Copy link
Contributor

Changes proposed in this pull request:

  • Clarify use of Lets Encrypt and relating to GSA policy

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None. Linking to internal GSA documentation is safe.

@pburkholder pburkholder requested review from ChrisMcGowan and a team December 14, 2023 16:04
@pburkholder pburkholder merged commit abf9a7c into main Dec 14, 2023
1 check passed
@pburkholder pburkholder deleted the peterb/letsencrypt branch December 14, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameshochadel jameshochadel jameshochadel approved these changes

@ChrisMcGowan ChrisMcGowan Awaiting requested review from ChrisMcGowan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pburkholder @jameshochadel