custodian lambdas - graviton support #7917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
architecture should primarily be determined by the host, instead of being a configuration option, and match the host so we don't have to deal with mismatches on binaries/extensions. [update] that's looks like what this does, so 👍 |
PratMis
changed the title
|
I was able to test this on both x86 and arm64 instances. |
|
@kapilt @thisisshi, this is ready for review now. Do you mind taking a look? Thanks |
PratMis
changed the title
kentnsw
pushed a commit
to newscorp-ghfb/cloud-custodian
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #7134
As per our discussion wrt to deciding the
Architecturefor custodian lambdas, now that arm64 base images is out, i put together this small change to the previous PR we had. Still need to write tests.