Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster details to config #423

Closed
wants to merge 1 commit into from

Conversation

smalleni
Copy link
Collaborator

@smalleni smalleni commented Apr 6, 2022

Signed-off-by: Sai Sindhur Malleni [email protected]

Description

Fixes

Signed-off-by: Sai Sindhur Malleni <[email protected]>
@smalleni smalleni marked this pull request as draft April 6, 2022 23:02
@rsevilla87
Copy link
Member

rsevilla87 commented Apr 7, 2022

Hey @smalleni, I think this PR is not neccsary since we're already indexing this metadata in e2e-benchmarking since this PR was merged: cloud-bulldozer/e2e-benchmarking#346

You should see the metadata document available in the same uperf index.

@smalleni
Copy link
Collaborator Author

smalleni commented Apr 7, 2022

Hey @smalleni, I think this PR is not neccsary since we're already indexing this metadata in e2e-benchmarking since this PR was merged: cloud-bulldozer/e2e-benchmarking#346

You should see the metadata document available in the same uperf index.

Ah, thanks for pointing out Raul!

@smalleni
Copy link
Collaborator Author

smalleni commented Apr 7, 2022

Closing as per Raul's feedback that this is already done in e2e utils/common.sh

@smalleni smalleni closed this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants