Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logger #30

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Add logger #30

merged 2 commits into from
Dec 4, 2023

Conversation

yunkon-kim
Copy link
Member

This PR will add a Zerolog-based logger.

It includes the following:

  • a logger package to initialize Zerolog globally,
  • environment variable for logger,
  • updating logger-related env variable on Dockerfile, and
  • applying the logger in some code blocks for testing.

You can find some related content at #29 (comment).

@yunkon-kim
Create logger package to initialize
720fbc3 
- Include init() only
- Support multi-writer, log level, and env.
- Add configuration values related to logging to setup.env
@yunkon-kim
Update logger init() and setup.env
948bd73
seokho-son
seokho-son approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seokho-son seokho-son merged commit 3c2c577 into cloud-barista:main Dec 4, 2023
4 checks passed
@yunkon-kim yunkon-kim deleted the add-logger branch December 8, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunkon-kim @seokho-son