Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance external model reference, Makefile, and CI workflow #102

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

yunkon-kim
Copy link
Member

This PR includes several key improvements and updates:

  • Improve reference to external models:

    • Modify the part that used the internally copied models to use the external models.
    • Remove the copied models from the external subsystems.
  • Improve various parts of the Makefile:

    • Enhance Makefile to refer to external modules when creating API documentation (swag init).
    • Add and improve various targets: dependency, lint, update, swag, swagger, build, arm, prod, run, stop, clean, help.
    • Specify targets to be linked and executed as needed.
    • Remove unnecessary sub-Makefiles.
  • Update CI workflow for Makefile changes:

    • Update CI workflow to accommodate changes in the Makefile.

Related to #33 #42 #71

* Modify the part that used the internally copied models to use the external models
* Remove the copied models from the external subsystems
* Improve to refer to external modules when creating API documentation (`swag init`).
* Add and improve targets, which are all dependency lint update swag swagger build arm prod run stop clean help
* Specify targets to be linked and executed (if necessary)
* Delete unnecessary sub-Makefiles
@yunkon-kim yunkon-kim requested a review from seokho-son as a code owner July 18, 2024 06:22
@yunkon-kim yunkon-kim changed the title Enhance External Model Reference, Makefile, and CI Workflow Enhance external model reference, Makefile, and CI workflow Jul 18, 2024
* This is an issue when building a container image
@yunkon-kim
Copy link
Member Author

/approve

@github-actions github-actions bot added the approved This PR is approved and will be merged soon. label Jul 18, 2024
@yunkon-kim yunkon-kim merged commit a595b13 into cloud-barista:main Jul 18, 2024
2 checks passed
@yunkon-kim yunkon-kim deleted the 240716-20 branch July 30, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved and will be merged soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant