-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test scripts [skip ci] #715
Merged
seokho-son
merged 3 commits into
cloud-barista:main
from
jihoon-seo:210908_Update_test_scripts
Sep 8, 2021
Merged
Update test scripts [skip ci] #715
seokho-son
merged 3 commits into
cloud-barista:main
from
jihoon-seo:210908_Update_test_scripts
Sep 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokho-son
reviewed
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jihoon-seo 출력 방식 관련 의견이 있습니다.. ^^
Comment on lines
41
to
50
if [ "${INDEX}" == "0" ]; then | ||
echo "[Parallel excution for all CSP regions]" | ||
|
||
INDEXX=${NumCSP} | ||
for ((cspi = 1; cspi <= INDEXX; cspi++)); do | ||
echo $i | ||
INDEXY=${NumRegion[$cspi]} | ||
CSP=${CSPType[$cspi]} | ||
for ((cspj = 1; cspj <= INDEXY; cspj++)); do | ||
# INDEX=$(($INDEX+1)) | ||
|
||
echo $j | ||
INDEX=$cspi | ||
REGION=$cspj | ||
echo $CSP | ||
echo $REGION | ||
echo ${RegionName[$cspi,$cspj]} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref) #714
Suggested change
if [ "${INDEX}" == "0" ]; then | |
echo "[Parallel excution for all CSP regions]" | |
INDEXX=${NumCSP} | |
for ((cspi = 1; cspi <= INDEXX; cspi++)); do | |
echo $i | |
INDEXY=${NumRegion[$cspi]} | |
CSP=${CSPType[$cspi]} | |
for ((cspj = 1; cspj <= INDEXY; cspj++)); do | |
# INDEX=$(($INDEX+1)) | |
echo $j | |
INDEX=$cspi | |
REGION=$cspj | |
echo $CSP | |
echo $REGION | |
echo ${RegionName[$cspi,$cspj]} | |
if [ "${INDEX}" == "0" ]; then | |
echo "[Parallel excution for all CSP regions]" | |
INDEXX=${NumCSP} | |
for ((cspi = 1; cspi <= INDEXX; cspi++)); do | |
INDEXY=${NumRegion[$cspi]} | |
CSP=${CSPType[$cspi]} | |
echo "[$cspi] $CSP details" | |
for ((cspj = 1; cspj <= INDEXY; cspj++)); do | |
echo "[$cspi,$cspj] ${RegionName[$cspi,$cspj]}" | |
이런 식으로 출력을 간소화하면 어떨까요?
jihoon-seo
force-pushed
the
210908_Update_test_scripts
branch
from
September 8, 2021 06:24
fad66df
to
9f7caa3
Compare
/approve |
감사합니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #677 (Change method to input parameters for script)
(일부 테스트 스크립트 파일에는 여전히 미적용되었을 수 있음)