Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rest api for vpc subnet #325

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Add rest api for vpc subnet #325

merged 1 commit into from
Jan 26, 2021

Conversation

jmleefree
Copy link
Member

  • VPC Subnet 를 위한 Common 함수 구현
  • VPC Subnet 를 를 위한 Rest API 추가
  • [Fix] Mock driver 의 AddSubnet() 함수에서 Subnet SystemId 설정

@powerkimhub powerkimhub self-requested a review January 26, 2021 06:21
@powerkimhub
Copy link
Member

@jmleefree

  • Awesome~, Thanks for your contribution!!
  • 혹시, 테스트 프로그램이나 shell 스크립트를 사용했나요?

@jmleefree
Copy link
Member Author

테스트 프로그램등은 가장 마지막에 적용될 예정입니다.
다음에는 WebAdminTool 과 gRPC 등을 진행할 예정입니다.

@powerkimhub
Copy link
Member

@jmleefree
It's Best Plans.
Thanks Thanks^^

@powerkimhub powerkimhub merged commit e956200 into cloud-barista:master Jan 26, 2021
powerkimhub
powerkimhub reviewed Jan 26, 2021
View reviewed changes
Copy link
Member

@powerkimhub powerkimhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@jmleefree jmleefree deleted the add-subnet-rest-api branch January 27, 2021 01:43
@powerkimhub powerkimhub mentioned this pull request Jan 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerkimhub powerkimhub powerkimhub left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmleefree @powerkimhub