Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tencent] VM spec - memory - MB vs. GB #488

Closed
jihoon-seo opened this issue Oct 21, 2021 · 3 comments · Fixed by #491
Closed

[Tencent] VM spec - memory - MB vs. GB #488

jihoon-seo opened this issue Oct 21, 2021 · 3 comments · Fixed by #491
Assignees
Labels
bug Something isn't working CloudDriver

Comments

@jihoon-seo
Copy link
Member

What happened
:

Tencent VM spec 조회하면
메모리 용량이 잘못 표시됨 (MB vs. GB) 😊

image

What you expected to happen
:

How to reproduce it (as minimally and precisely as possible)
:

Anything else we need to know?
:

Environment

  • Source version or branch:
  • OS:
  • Others:

Proposed solution
:

  • 1024로 나누는 코드를 없애거나
  • 1024를 곱하는 코드를 넣거나
  • ... 😊

Any other context
:

@jihoon-seo jihoon-seo added the bug Something isn't working label Oct 21, 2021
@powerkimhub
Copy link
Member

@dev4unet

  • 확인 부탁 드립니다.

@dev4unet
Copy link
Member

@powerkimhub 현재 소스를 살펴 보니 AWS / GCP / Tencent는 그대로 보내고 있고 Alibaba는 1024를 곱해서 전송하고 있네요.
Tencent의 경우 숫자를 그대로 리턴하고 있으며 API에서 GB단위로 보내고 있습니다.
https://intl.cloud.tencent.com/ko/document/api/213/15753#InstanceTypeConfig

Tencent의 경우 제쪽에서 /1024를 해야하면 알려 주시면 수정하겠습니다.
{
"Zone": "ap-seoul-1",
"InstanceFamily": "S2",
"InstanceType": "S2.SMALL1",
"CPU": 1,
"GPU": 0,
"FPGA": 0,
"Memory": 1
},
{
"Zone": "ap-seoul-1",
"InstanceFamily": "S3",
"InstanceType": "S3.SMALL1",
"CPU": 1,
"GPU": 0,
"FPGA": 0,
"Memory": 1
},

@powerkimhub
Copy link
Member

@dev4unet

  • MB로 올려주시면 되겠습니다.
  • 참고로, VMSpec 관련 Cloud driver common interface 규격 공유 드립니다.

image

powerkimhub added a commit that referenced this issue Oct 22, 2021
텐센트 이슈 #488 처리 - 메모리 단위를 GB->MB로 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CloudDriver
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants