Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make plugin compatible with Docusaurus beta.13 #88

Merged
merged 6 commits into from
Dec 13, 2021

Conversation

Josh-Cena
Copy link
Contributor

Fix #87. See facebook/docusaurus#6047. This change was made in the core to resolve circular dependencies. Sorry for not marking it as breaking change—we aren't expecting anyone to use such implementation detail (at least previously). As now it's found its home in utils, we can assert that it will be stable as long as the architecture isn't completely overhauled.

@bourdakos1
Copy link
Member

Haha no worries, I assumed importing directly from the lib folder would be fragile and have unannounced breaking changes. I appreciate the PR ❤️

@Josh-Cena Josh-Cena changed the title refactor: import constants from docusaurus-utils fix: make plugin compatible with Docusaurus beta.13 Dec 12, 2021
@Josh-Cena
Copy link
Contributor Author

Josh-Cena commented Dec 13, 2021

This is hard 🤦‍♂️ Because of facebook/docusaurus#6087 the theme fails to build, but the theme-classic/index file is only used to import a type that we don't use... I tried skipLibCheck with no luck. If this project is using Yarn berry I would suggest doing a patch package. @bourdakos1 would you be willing to migrate to Yarn berry?

@bourdakos1
Copy link
Member

@Josh-Cena Oh, wow thanks for all the work you've put in to this! I think I can fix the typescript issue. I'll checkout your branch and see if I can get it working

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 806d118:

Sandbox Source
demo Configuration

@Josh-Cena
Copy link
Contributor Author

Oh hehe, I did add declare module for the theme but I forgot to add it to the preset... Thanks for the fix

@bourdakos1
Copy link
Member

No problem :) Thanks for everything you've done, really appreciate it

@bourdakos1 bourdakos1 merged commit 56e6b80 into cloud-annotations:main Dec 13, 2021
@Josh-Cena Josh-Cena deleted the patch-1 branch December 13, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of Docusaurus Constants has changed
2 participants