-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nylas auth refactor #27
Conversation
704eedd
to
3db897b
Compare
3db897b
to
30bf14d
Compare
de7bc81
to
8521b90
Compare
0c295c0
to
ae2979b
Compare
ae2979b
to
01a9802
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything here really objectionable, but the size of this diff makes me nervous.
Beyond automated tests, are we going to do any more testing internally before merging this?
2cb5e53
to
aae53db
Compare
aae53db
to
d4a869c
Compare
7090e5a
to
6f84ac8
Compare
a564179
to
582936b
Compare
c722dd7
to
243f709
Compare
@AlecRosenbaum Take another look please. The tests should now pass and I did some more local testing. I will still do further testing this week. |
bde26db
to
cee792c
Compare
cee792c
to
b1551b4
Compare
d7ea39f
to
b9987a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of stuff going on here so hopefully I didn't miss anything too major.
If possible we should try to add rollbar support before we test this so error response is more proactive than reactive.
"email", # email address | ||
"https://mail.google.com/", # email | ||
"https://www.google.com/m8/feeds", # contacts | ||
"https://www.googleapis.com/auth/calendar", # calendar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need any of the profile information? And they're not reusing the G+ scope for other profile information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The profile info was filled in the Gmail account table but is not needed for the sync, so I took it out.
I also definitely think we should merge this separate from actual AuthAlligator integration, primarily to get a baseline that this works and to make it easier to review the more authalligator-specific changes (beyond |
b650b01
to
9aa5504
Compare
GmailAuthCredentials
table. We only support one app token.TokenManager
which can use a refresh token or AuthAlligator (not implemented yet).get_authenticated_imap_connection
for convenience.gdata.gauth.AuthSubToken
with the token from the token manager.To do:
Future to-dos: