Update JSON serializer to serialize to a locale-independent format #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmat Note that this is a breaking change because the serialization format has been changed.
|
Thank you! |
|
@gws please submit a PR that updates change log and credit yourself :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #9, the JSON serializer was formatting Money values in a locale-dependent format. This change updates the serialization format to one that can be read back in by
clojurewerkz.money.amounts/parse.Note that this will break backward compatibility, but based on discussion in #9 it seems that may not be a problem.
I did not see an opportunity here for encoding
Moneyobjects in a locale-dependent format - only one encoder can be added to cheshire for Money objects, and cheshire does not offer an opportunity for selecting between multiple encoders that I can see.