Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read-ns-form: rethrow FileNotFoundExceptions more informatively #368

Merged
merged 6 commits into from
Feb 10, 2022
Merged

Conversation

vemv
Copy link
Member

@vemv vemv commented Feb 9, 2022

  • read-ns-form: rethrow FileNotFoundExceptions more informatively
    • Simply rethrows this exception if it arises with particularly useful wording and ex-data. Otherwise logic isn't changed at all.
    • Fixes move form refactoring doesn't follow symlinks #142
      • (That issue has nothing actionable refactor-nrepl side, it's a clj-refactor.el bug)
  • Bump Eastwood

@@ -152,28 +152,28 @@

(defn read-ns-form
([path]
(let [^String path-string (when (string? path)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRYed out the duplication across the two arities of read-ns-form.

Took care of making them 100% equivalent. The key is here:

(if dialect
  {:read-cond :allow :features #{dialect}}
  nil)

The nil value makes readers/indexing-push-back-reader behave exactly as if it hadn't received this argument at all.

@vemv vemv merged commit 6529ec0 into master Feb 10, 2022
@vemv vemv deleted the 142-v2 branch February 10, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move form refactoring doesn't follow symlinks
1 participant