Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate required clj version #132

Closed
expez opened this issue Dec 19, 2015 · 1 comment
Closed

Validate required clj version #132

expez opened this issue Dec 19, 2015 · 1 comment
Labels
enhancement

Comments

@expez
Copy link
Member

expez commented Dec 19, 2015

see clojure-emacs/cider-nrepl#278 for how this is done in cider
@cichli
Copy link
Member

cichli commented Dec 21, 2015

It's probably worth additionally checking that cider-nrepl is included and of the correct version too - currently, if I include both plugins but the version checks fail, then the REPL still fails to start because refactor-nrepl has cider-nrepl as a provided dep.

@expez expez closed this as completed in 2918bca Jan 28, 2016
benedekfazekas added a commit that referenced this issue Jan 31, 2016
@benedekfazekas
Move version fn from plugin ns to core ns
cb72cd9 
enables #132 and fixes broken lein plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@expez @cichli