Correct namespace prefix for inlined deps #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpsutton
pushed a commit
to dpsutton/cider-nrepl
that referenced
this pull request
Jun 23, 2019
The required structure for the 'query/var' function is `{:var-query
{:ns-query {...}}`. The older implementation did not grab those
keywords from the cider message and put them at the correct
level. they were left top level and then missed by the
`query/namespace` function.
In addition to this, there was a bug in orchard which had the wrong
prefix for inlined deps so these were not omitted in _2_ places: both
in the client-side specification of which namespaces to ignore and
orchard's own mechanism to elide cider's internal namespaces.
See related:
- orchard clojure-emacs/orchard#59
- CIDER
5 tasks
dpsutton
pushed a commit
to dpsutton/cider
that referenced
this pull request
Jun 23, 2019
Confluence of bugs in orchard, cider-nrepl, and CIDER. CIDER was using the wrong key to send excluded namespaces. cider-nrepl was not putting this key in the right position for the orchard query. And orchard was not correctly eliding cider.nrepl inlined deps. - orchard: clojure-emacs/orchard#59 - nrepl: clojure-emacs/cider-nrepl#618
6 tasks
dpsutton
pushed a commit
to dpsutton/cider-nrepl
that referenced
this pull request
Jun 23, 2019
The required structure for the 'query/var' function is `{:var-query
{:ns-query {...}}`. The older implementation did not grab those
keywords from the cider message and put them at the correct
level. they were left top level and then missed by the
`query/namespace` function.
In addition to this, there was a bug in orchard which had the wrong
prefix for inlined deps so these were not omitted in _2_ places: both
in the client-side specification of which namespaces to ignore and
orchard's own mechanism to elide cider's internal namespaces.
See related:
- orchard clojure-emacs/orchard#59
- CIDER clojure-emacs/cider#2658
dpsutton
pushed a commit
to dpsutton/cider-nrepl
that referenced
this pull request
Jun 23, 2019
The required structure for the 'query/var' function is `{:var-query
{:ns-query {...}}`. The older implementation did not grab those
keywords from the cider message and put them at the correct
level. they were left top level and then missed by the
`query/namespace` function.
In addition to this, there was a bug in orchard which had the wrong
prefix for inlined deps so these were not omitted in _2_ places: both
in the client-side specification of which namespaces to ignore and
orchard's own mechanism to elide cider's internal namespaces.
See related:
- orchard clojure-emacs/orchard#59
- CIDER clojure-emacs/cider#2658
dpsutton
pushed a commit
to dpsutton/cider
that referenced
this pull request
Jun 23, 2019
Confluence of bugs in orchard, cider-nrepl, and CIDER. CIDER was using the wrong key to send excluded namespaces. cider-nrepl was not putting this key in the right position for the orchard query. And orchard was not correctly eliding cider.nrepl inlined deps. - orchard: clojure-emacs/orchard#59 - nrepl: clojure-emacs/cider-nrepl#618
dpsutton
force-pushed
the
correct-inlined-deps-path
branch
from
b00f8f3 to
cc2944d
Compare
bbatsov
reviewed
Jun 24, 2019
src/orchard/xref.clj
Outdated
| @@ -47,7 +47,9 @@ | |||
| {:added "0.5"} | |||
| [var] | |||
| (let [var (as-var var) | |||
| all-vars (q/vars {:ns-query {:project? true} :private? true}) | |||
| all-vars (q/vars {:ns-query {:project? true | |||
| :exclude-regexps ["^cider.nrepl.inlined-deps" "^nrepl"]} | |||
There was a problem hiding this comment.
I think we should probably put the list of exclusions in some var that we can just check where this is needed.
I also wonder if it won't better for the query methods to just filter those out automatically.
There was a problem hiding this comment.
The q/namespace function does filter it out. It just had the wrong prefix. This technically isn't needed.
There was a problem hiding this comment.
I reset the branch to just the single commit and force pushed. no longer there.
dpsutton
force-pushed
the
correct-inlined-deps-path
branch
from
1c098f0 to
cc2944d
Compare
|
Thanks! |
bbatsov
pushed a commit
to clojure-emacs/cider
that referenced
this pull request
Jun 24, 2019
Confluence of bugs in orchard, cider-nrepl, and CIDER. CIDER was using the wrong key to send excluded namespaces. cider-nrepl was not putting this key in the right position for the orchard query. And orchard was not correctly eliding cider.nrepl inlined deps. - orchard: clojure-emacs/orchard#59 - nrepl: clojure-emacs/cider-nrepl#618
bbatsov
pushed a commit
to clojure-emacs/cider-nrepl
that referenced
this pull request
Jun 25, 2019
The required structure for the 'query/var' function is `{:var-query
{:ns-query {...}}`. The older implementation did not grab those
keywords from the cider message and put them at the correct
level. they were left top level and then missed by the
`query/namespace` function.
In addition to this, there was a bug in orchard which had the wrong
prefix for inlined deps so these were not omitted in _2_ places: both
in the client-side specification of which namespaces to ignore and
orchard's own mechanism to elide cider's internal namespaces.
See related:
- orchard clojure-emacs/orchard#59
- CIDER clojure-emacs/cider#2658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR make sure the following things have been done:
Apropos is broken right now and including inlined deps for this reason and another reason that will be patched on cider-nrepl and cider soon.