Remove dynapath, accomodate enrich-classpath
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
commented
Dec 13, 2021
| [_] | ||
| nil) | ||
|
|
||
| (def ^:deprecated jdk-sources nil) |
There was a problem hiding this comment.
From what I pondered on previous iterations: ^:deprecated + no-op impls are the least breaking choice
(as opposed to an (assert false))
| @@ -56,26 +50,26 @@ | |||
| (.split (System/getProperty "java.class.path") | |||
| (System/getProperty "path.separator")))) | |||
|
|
|||
| (defn classpath-urls [classloader] | |||
There was a problem hiding this comment.
This is (essentially) what dp/classpath-urls was doing
|
|
||
| (defn compile-class-from-source |
There was a problem hiding this comment.
Now compilation for this test case happens via Lein :java-source-paths, it reflects typical end-user usage and also exercises what enrich-classpath does / is able to do (it's not able to modify classpaths at runtime, and we don't want that either!)
bbatsov
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
Fixes #120
Fixes #105
Fixes #103
Fixes #50