Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: timbre support #8

Closed
yenda opened this issue Nov 13, 2023 · 6 comments · Fixed by #10
Closed

Feature: timbre support #8

yenda opened this issue Nov 13, 2023 · 6 comments · Fixed by #10
Assignees
@vemv

Comments

@yenda
Copy link

yenda commented Nov 13, 2023

Would be great to have timbre supported as a framework. The lib doesn’t use any Java framework
@vemv
Copy link
Member

vemv commented Nov 13, 2023

@r0man 👋, is Timbre support something that we had considered?

@r0man
Copy link
Collaborator

r0man commented Nov 15, 2023

I only looked at the Java logging frameworks so far, JUL, Logback, and Log4j.
Looking at https://github.com/taoensso/timbre/wiki/2-Appenders I think it is doable.
I think we would need to merge our own appender into Timbre's config when we attach to it, and remove it when we detach.

@vemv
Copy link
Member

vemv commented Nov 15, 2023

Sounds reasonable!

@vemv
Copy link
Member

vemv commented Dec 14, 2023

I'll work on this one

@vemv vemv self-assigned this Dec 14, 2023
@vemv vemv mentioned this issue Jan 4, 2024
Merged
@vemv vemv closed this as completed in #10 Jan 4, 2024
vemv added a commit that referenced this issue Jan 4, 2024
@vemv
Introduce Timbre support (#10)
cc9d777 
Closes #8
@vemv
Copy link
Member

vemv commented Jan 4, 2024

This will be released CIDER-side later in the week 🎉

@vemv
Copy link
Member

vemv commented Jan 14, 2024

https://github.com/clojure-emacs/cider/releases/tag/v1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vemv vemv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce Timbre support clojure-emacs/logjam
3 participants
@r0man @vemv @yenda