Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node-env? #27

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Fix node-env? #27

merged 1 commit into from
Sep 13, 2021

Conversation

vemv
Copy link
Member

@vemv vemv commented Sep 13, 2021

Makes it nil-safe, while taking care of not comparing nil to nil.

It also fixes edge cases making it work as intended over various auto-generated classes.

Fixes #14

Makes it nil-safe, while taking care of not comparing nil to nil.

It also fixes edge cases making it work as intended over various auto-generated classes.

Fixes #14
Copy link
Member

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vemv vemv merged commit d0a34fe into master Sep 13, 2021
@vemv vemv deleted the 14--node-env branch September 13, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shadow-cljs REPL causes cider complete errors NullPointerException
2 participants