Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use styleguide formatting for cljr-add-missing-libspec #459

Closed
kwrooijen opened this issue Jan 8, 2020 · 2 comments
Closed

Use styleguide formatting for cljr-add-missing-libspec #459

kwrooijen opened this issue Jan 8, 2020 · 2 comments
Labels
help wanted low hanging fruit

Comments

@kwrooijen
Copy link

Currently when using cljr-add-missing-libspec, the namespaces are inline with the :require keyword.

It is formatted as the good example of the community styleguide instead of the better example.

Wouldn't it make sense to have it format to the better example?
Or is the documentation maybe outdated and should better / good be swapped?
@expez
Copy link
Member

expez commented Jan 9, 2020

Sure, a PR that fixes this would be welcome.

This would require work in our sister repo, refactor-nrepl, as it's the middleware that takes care of making the ns tidy (with the clean-ns operation). Most likely the edit is needed in our homemade pretty-printing code

Not a bad first issue to take on, if you want to get familiar with the code base.

@kwrooijen
Copy link
Author

Thanks for the info, I'll see if I can take a look.

expez added a commit to clojure-emacs/refactor-nrepl that referenced this issue Jun 24, 2021
@expez
Improve pretty-printing of namespaces
ffe3e41 
This makes the pretty-printed namespace form more in line with the
clojure style guide.

Specifically we go from:

```
(ns foo.bar
  (:require [this.library :as lib]))
```

To:

```
(ns foo.bar
  (:require
    [this.library :as lib]))
```

This commit closes clojure-emacs/clj-refactor.el#459
expez added a commit to clojure-emacs/refactor-nrepl that referenced this issue Jun 24, 2021
@expez
Improve pretty-printing of namespaces
c0eece5 
This makes the pretty-printed namespace form more in line with the
clojure style guide.

Specifically we go from:

```
(ns foo.bar
  (:require [this.library :as lib]))
```

To:

```
(ns foo.bar
  (:require
    [this.library :as lib]))
```

This commit closes clojure-emacs/clj-refactor.el#459
expez added a commit to clojure-emacs/refactor-nrepl that referenced this issue Jun 24, 2021
@expez
Improve pretty-printing of namespaces
40aaf72 
This makes the pretty-printed namespace form more in line with the
clojure style guide.

Specifically we go from:

```
(ns foo.bar
  (:require [this.library :as lib]))
```

To:

```
(ns foo.bar
  (:require
    [this.library :as lib]))
```

This commit closes clojure-emacs/clj-refactor.el#459
expez added a commit to clojure-emacs/refactor-nrepl that referenced this issue Jun 24, 2021
@expez
Improve pretty-printing of namespaces
19cde70 
This makes the pretty-printed namespace form more in line with the
clojure style guide.

Specifically we go from:

```
(ns foo.bar
  (:require [this.library :as lib]))
```

To:

```
(ns foo.bar
  (:require
    [this.library :as lib]))
```

This commit closes clojure-emacs/clj-refactor.el#459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted low hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwrooijen @expez