Add buffer-local caching to friendly-session calculation #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seconds are too coarse-grained and can foil caching.
vemv
commented
Sep 13, 2023
| @@ -305,8 +305,15 @@ whether DIRECTION is 'from-nrepl or 'to-nrepl." | |||
| (seq-filter #'identity (mapcar f cider-path-translations)) | |||
| (seq-some f cider-path-translations))))) | |||
|
|
|||
| (defun cider--unix-time () | |||
| "Returns the Unix time." | |||
| (float-time)) | |||
There was a problem hiding this comment.
Ideally I'd get the time in nanoseconds, as integer. floats make me nervous :)
There was a problem hiding this comment.
What's wrong with using (current-time)? Sure, it uses seconds, but I'm guessing that'd be fine for your use case.
There was a problem hiding this comment.
I found out that seconds are too coarse-grained for timestamp comparisons.
Say that it was all computed in less than second, we'd get the same timestamp so > wouldn't succeed (and >= may not be as optimal to use)
|
I'll retake this PR after we get to address #3468 - otherwise not cool to further touch this area with a release around the corner |
|
Might be a good time to revisit this for the next minor release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friendly session calculation has always be at least a touch slow (ref, ref), and even more so following recent additions to it.
All slow paths have in common that they run
seq-findover a series of sequences (the classpath, classpath roots, the ns list). Those can be arbitrarily large.We may do relatively expensive stuff for each element, like trying to match a string.
So, this PR adds buffer-local caching.
The buffer-local caching is essentially this map:
<repl buffer>-><is this buffer considered friendly to it?>There are timestamps to ensure that we're not basing the caching on stale data.
From a quick test, it appears to work. Anyway I'll keep this as a draft to give it at least a couple days of QAing. Review welcome!