-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify cider-boot-parameters to match the new boot task #2379
Conversation
I have tested this with a Clojure file and no problem. There is still a problem with the cljs REPL, which is probably going to need a change in |
Nice!
@arichiardi I guess you'll take care of those, right? What are those problems, btw? |
A couple of deps are outdated, see adzerk-oss/boot-cljs-repl#60. About taking care of those, it is very low in my priority atm because I have switched to The only thing I am afraid of is that I am not very familiar with the changes to piggieback, so probably I need to spend some time for learning things there: |
Yeah, I get this. Seems this boot-cljs-repl is not getting any love these days, but I doubt many people are using it.
Isn't it just using piggieback? |
It seems so, so maybe it is an easy one after all, will try smth out before talking nonsense again 😄 |
Oh, it's using Weasel as well... The changes required really are trivial, but if there isn't anyone to merge them, that's a problem... |
So this one can go in now? |
Yeah, we'll merge this soon. The only holdup right now is |
Let's get wild! ;-) |
Woot! |
This follows changes in
cider-nrepl
introducing the newnrepl-server
boottask.
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):