Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify cider-boot-parameters to match the new boot task #2379

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

arichiardi
Copy link
Contributor

This follows changes in cider-nrepl introducing the new nrepl-server boot
task.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

@arichiardi
Copy link
Contributor Author

I have tested this with a Clojure file and no problem. There is still a problem with the cljs REPL, which is probably going to need a change in boot-cljs-repl.

@bbatsov
Copy link
Member

bbatsov commented Jul 21, 2018

Nice!

I have tested this with a Clojure file and no problem. There is still a problem with the cljs REPL, which is probably going to need a change in boot-cljs-repl.

@arichiardi I guess you'll take care of those, right? What are those problems, btw?

@arichiardi
Copy link
Contributor Author

A couple of deps are outdated, see adzerk-oss/boot-cljs-repl#60.

About taking care of those, it is very low in my priority atm because I have switched to shadow-cljs and figwheel-main. I will definitely be able to help there though or do it myself at some point.

The only thing I am afraid of is that I am not very familiar with the changes to piggieback, so probably I need to spend some time for learning things there: boot-cljs-repl seems to do something very similar.

@bbatsov
Copy link
Member

bbatsov commented Jul 23, 2018

About taking care of those, it is very low in my priority atm because I have switched to shadow-cljs and figwheel-main. I will definitely be able to help there though or do it myself at some point.

Yeah, I get this. Seems this boot-cljs-repl is not getting any love these days, but I doubt many people are using it.

The only thing I am afraid of is that I am not very familiar with the changes to piggieback, so probably I need to spend some time for learning things there: boot-cljs-repl seems to do something very similar.

Isn't it just using piggieback?

@arichiardi
Copy link
Contributor Author

Isn't it just using piggieback?

https://github.com/adzerk-oss/boot-cljs-repl/blob/master/src/adzerk/boot_cljs_repl.clj#L18-L21

It seems so, so maybe it is an easy one after all, will try smth out before talking nonsense again 😄

@bbatsov
Copy link
Member

bbatsov commented Jul 24, 2018

Oh, it's using Weasel as well... The changes required really are trivial, but if there isn't anyone to merge them, that's a problem...

@arichiardi
Copy link
Contributor Author

So this one can go in now?

@bbatsov
Copy link
Member

bbatsov commented Aug 4, 2018

Yeah, we'll merge this soon. The only holdup right now is refactor-nrepl, but I'm not that concerned about it.

@bbatsov bbatsov merged commit 6147c73 into clojure-emacs:master Aug 6, 2018
@bbatsov
Copy link
Member

bbatsov commented Aug 6, 2018

Let's get wild! ;-)

@arichiardi arichiardi deleted the boot-nrepl-changes branch August 7, 2018 02:21
@arichiardi
Copy link
Contributor Author

Woot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants