Replace if-let and when-let with starred versions
#2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiongtx
force-pushed
the
2130-if-let-when-let
branch
2 times, most recently
from
c7a976e to
fcbaadb
Compare
bbatsov
reviewed
Dec 11, 2017
CHANGELOG.md
Outdated
| @@ -14,6 +14,7 @@ | |||
| * [#2078](https://github.com/clojure-emacs/cider/pull/2078): Improve startup time by bundling together sync requests during startup. | |||
| * `cider-rotate-default-connection` will warn if you use it with only a single active connection. | |||
| * `cider-format-buffer` preserves the point position. | |||
| * [#2132](https://github.com/clojure-emacs/cider/pull/2132): Replace `if-let` and `when-let` with starred versions [per Emacs 26](http://git.savannah.gnu.org/cgit/emacs.git/tree/etc/NEWS?h=emacs-26#n1278). | |||
There was a problem hiding this comment.
That's not a user-visible change, so we shouldn't put in in the changelog.
bbatsov
reviewed
Dec 11, 2017
cider-overlays.el
Outdated
| (format (concat " " cider-eval-result-prefix "%s ")) | ||
| (prepend-face 'cider-result-overlay-face) | ||
| &allow-other-keys) | ||
| (format (concat " " cider-eval-result-prefix "%s ")) |
There was a problem hiding this comment.
We should all get in the good habit of putting whitespace-cleanup in before-save-hook 😛.
There was a problem hiding this comment.
Yeah, I get how this happened, I just don't unrelated changes in commits. Btw, even the fixed indentation seems wrong for some reason. cl-defun should be indented as defun.
xiongtx
force-pushed
the
2130-if-let-when-let
branch
from
fcbaadb to
26c6d0b
Compare
Fix clojure-emacs#2130. Emacs 26 obsoletes `if-let` and `when-let`, replacing them with `if-let*` and `when-let*`. This raises byte-compilation warnings (treated as errors) when testing against Emacs 26. See: http://git.savannah.gnu.org/cgit/emacs.git/tree/etc/NEWS?h=emacs-26#n1278
xiongtx
force-pushed
the
2130-if-let-when-let
branch
from
26c6d0b to
ab1bbdd
Compare
|
Thanks for taking care of this, @xiongtx! You rock! 🎸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emacs 26 obsoletes
if-letandwhen-let, replacing them withif-let*andwhen-let*. This raises byte-compilation warnings (treated as errors) when testing against Emacs 26.