-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2120] fix TLS related errors in Travis CI #2128
Merged
bbatsov
merged 1 commit into
clojure-emacs:master
from
gonewest818:2120-travis-tls-errors
Dec 11, 2017
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Setup a newer gnutls-cli on Travis CI | ||
| # We need this as long as the Travis workers are Ubuntu 14.04 | ||
| # and the TLS cert chain on elpa.gnu.org is out-of-order | ||
|
|
||
| set -x | ||
|
|
||
| # adjust these versions as needed | ||
| export NETTLE_VERSION=3.4 | ||
| export GNUTLS_VERSION=3.5.16 | ||
|
|
||
| export WORKDIR=${HOME}/local/ | ||
| export LD_LIBRARY_PATH=${WORKDIR}/lib/ | ||
| export PKG_CONFIG_PATH=${WORKDIR}/lib/pkgconfig/ | ||
|
|
||
| # exit if the cache is valid and up-to-date | ||
| if [ -f ${WORKDIR}/bin/gnutls-cli ] && \ | ||
| [ -f ${WORKDIR}/nettle-${NETTLE_VERSION}.tar.gz ] && \ | ||
| [ -f ${WORKDIR}/gnutls-${GNUTLS_VERSION}.tar.xz ] | ||
| then | ||
| exit 0 | ||
| fi | ||
|
|
||
| # delete cache and rebuild | ||
| rm -rf $WORKDIR | ||
| mkdir $WORKDIR | ||
| cd $WORKDIR | ||
| curl -O https://ftp.gnu.org/gnu/nettle/nettle-${NETTLE_VERSION}.tar.gz \ | ||
| && tar xfz nettle-${NETTLE_VERSION}.tar.gz \ | ||
| && cd nettle-${NETTLE_VERSION} \ | ||
| && ./configure --prefix=${WORKDIR} \ | ||
| && make -j4 install \ | ||
| && make distclean | ||
|
|
||
| cd $WORKDIR | ||
| curl -O https://www.gnupg.org/ftp/gcrypt/gnutls/v3.5/gnutls-${GNUTLS_VERSION}.tar.xz \ | ||
| && xz -d -k gnutls-${GNUTLS_VERSION}.tar.xz \ | ||
| && tar xf gnutls-${GNUTLS_VERSION}.tar \ | ||
| && cd gnutls-${GNUTLS_VERSION} \ | ||
| && ./configure --prefix=${WORKDIR} \ | ||
| --with-included-libtasn1 \ | ||
| --with-included-unistring \ | ||
| --without-p11-kit \ | ||
| && make -j4 install \ | ||
| && make distclean |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbatsov Magit recently announced that it will stop supporting Emacs 24.4. Perhaps we can do that as well after the next release; the test matrix is getting rather large.
@tarsius any reason you've decided to stop supporting Emacs 24.4 recently? Emacs versions don't have a formal EOL AFAIK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking when it comes to bugfix releases, we should have in the matrix just the most recent. The matrix is indeed pretty big already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually I will have to do it anyway. For the upcoming release I have concentrated on doing many things that don't require major refactorings and new abstractions. After the release I will concentrate on things that are new abstractions that depend on features only available in > 25.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do older Emacs versions even get any fixes? Or is it fix-forward only? Since CIDER is an Emacs package, we should maintain support only to the extent that Emacs does, and no more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once or twice every decade a security fix is backported. Or not - the latest fix only resulted in the release of
25.3, but I don't know if that's because24wasn't affected or because it is no longer supported.