Created cider-eval-last-sexp-to-comment #2101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2017 19:29
…eful than cider-eval-defun-to-comment. You're able to eval to comment any sexp and not only functions. Also rebinded the shortcut C-c M-; to this new func.
bbatsov
reviewed
Oct 29, 2017
|
|
||
| With a prefix arg, LOC, insert before the form, otherwise afterwards." | ||
| (interactive "P") | ||
| (let* ((bounds (cider-defun-at-point 'bounds)) |
There was a problem hiding this comment.
Seems to me you just copy pasted the code of the other function here. :-)
The repetition between the two functions should be factored out into some common helper.
bbatsov
reviewed
Oct 29, 2017
| @@ -304,7 +304,7 @@ Configure `cider-cljs-*-repl' to change the ClojureScript REPL to use for your b | |||
| (define-key map (kbd "C-x C-e") #'cider-eval-last-sexp) | |||
| (define-key map (kbd "C-c C-e") #'cider-eval-last-sexp) | |||
| (define-key map (kbd "C-c C-v") 'cider-eval-commands-map) | |||
| (define-key map (kbd "C-c M-;") #'cider-eval-defun-to-comment) | |||
| (define-key map (kbd "C-c M-;") #'cider-eval-last-sexp-to-comment) | |||
There was a problem hiding this comment.
Unbinding functions like this is never a good idea. Try to think of a new binding for this function. Also mention it in the command listings in menus and documents.
|
@marcelotoledo Ping :-) |
7 tasks
|
Also, this should take into account the changes introduced in #2111. |
|
I'll close this for now due to lack of activity. Feel free to reopen it, if you I ever revisit it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created cider-eval-last-sexp-to-comment which is more flexible and useful than cider-eval-defun-to-comment. You're able to eval to comment any sexp and not only functions. Also rebinded the shortcut C-c M-; to this new func.