Correctly font-lock pretty-printed results at the REPL #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pretty-printing is enabled, the :value slot is elided from eval responses anyway.
bbatsov
added a commit
that referenced
this pull request
Dec 12, 2015
Correctly font-lock pretty-printed results at the REPL
Excellent! IMO this is one of the ugliest parts on the nrepl client and reworking it would make the entire codebase easier to comprehend/extend. This was on my radar for 0.10, but I never got any time to work on it. Hopefully you'll manage to get the ball rolling this time around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding another argument to
nrepl-make-response-handleris regrettable, but we have #1099 logged for untangling that. I'm going to take a look at fixing that soon - it will make it easier to solve the problem whereoutandpprint-outresponses are interleaved (e.g. in the face of concurrency or laziness).