Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger menu and configurable input prompt #1187

Merged
merged 4 commits into from
Jul 8, 2015
Merged

Debugger menu and configurable input prompt #1187

merged 4 commits into from
Jul 8, 2015

Conversation

Malabarba
Copy link
Member

  • The menu is pretty straightforward.
  • The configurable input prompt (the list of debug keys) can be shown on the minibuffer, on an overlay above the function, on both, or not at all. I think I'll make overlay the default, so the echo-area will be less crowded. When the top of the function is not visible, the top of the window is used instead.

What do you say?

@bbatsov
Copy link
Member

bbatsov commented Jul 7, 2015

I say "Aye!".

@bbatsov
Copy link
Member

bbatsov commented Jul 7, 2015

Hmm, something's wrong with Travis.

@Malabarba
Copy link
Member Author

At least it got to the compiling stage. I've got a package where half the time I can't get travis to clone the repo.

Did you try restarting the build?

@bbatsov
Copy link
Member

bbatsov commented Jul 8, 2015

Yep, I restarted it.

@Malabarba
Copy link
Member Author

Ah ok. I was reading it on my phone yesterday, and it looked like the build was stopping at the compile stage. But I see now it's just a normal tests thing. I'll get to it.

@Malabarba
Copy link
Member Author

Ok. it's passing now.

@Malabarba Malabarba closed this Jul 8, 2015
@Malabarba
Copy link
Member Author

Hold on, don't merge yet. After playing around on my work PC I realise I don't like the way this looks. I'll have to fine tune it a bit more.

Malabarba added 2 commits July 8, 2015 12:21
Now that the debugger is a minor-mode, it makes little sense to quit
it with C-g. Specially since the user can move around and mark stuff,
and C-g is used to clear the mark.
@Malabarba Malabarba reopened this Jul 8, 2015
@Malabarba
Copy link
Member Author

Ok, it works nicer now I think.
The previous version would remove the overlays immediately after the user sent a command, and recreate them when a new input-request was received. This caused a noticeable flicker on all the overlays, because Emacs actually has time to do a redisplay in between those two events.

The current version doesn't immediately remove the overlays, instead it removes them when the next input request is received or after a fraction of a second (whichever comes first). In my system, this is enough to avoid the flicker.

bbatsov added a commit that referenced this pull request Jul 8, 2015
Debugger menu and configurable input prompt
@bbatsov bbatsov merged commit 2c01b43 into clojure-emacs:master Jul 8, 2015
@bbatsov
Copy link
Member

bbatsov commented Jul 8, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants