-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmatched bracket or quote #587
Comments
I can't reproduce this. |
File
Eval |
I actually noted that it depends on when the point is when you do your C-x C-e |
@turbopape Yeah, you're right. The problem is that the sexp preceding the point is the symbol
( I guess we need a check if the last sexp is Java(Script) method name. |
We have a different problem. Seems that the exception info is not properly encoded and cannot be decoded.
This is unlikely to be a big problem in practice, but is pretty annoying never-the-less. //cc @gtrak @jeffvalk |
Yeesh. Is there a general solution to the arbitrary clojure data structures On Thu, May 29, 2014 at 12:03 PM, Bozhidar Batsov
|
Though, this looks like it might just be hitting an edge-case in the elisp On Thu, May 29, 2014 at 12:22 PM, Gary Trakhman [email protected]:
|
I'm pretty sure something's wrong with the elisp implementation as @cemerick wouldn't have chosen bencode otherwise. :-) Anyways, I'm not particularly thrilled to debug it... |
It might be a week or so before I get a chunk of time sufficient for this On Thu, May 29, 2014 at 12:30 PM, Bozhidar Batsov
|
Not sure what I can add here, but I was mentioned, so: keep in mind that bencode cannot represent everything that e.g. EDN can (nREPL's design predated EDN by some time, so it wasn't considered). That said, IIRC, nREPL's bencode encoder will "downcast" various sorts of Clojure structures to the closest bencode equivalents (e.g. sets -> lists). Beyond this detail, I'd presume that any issues are implementation-dependent. |
Is there bencode reference implementation that we might test both the client and server against? It would beat the guesswork. |
@jeffvalk I guess we can consider whatever nREPL is using as the reference implementation. |
That's what I've been doing up to this point, I haven't found anything On Thu, May 29, 2014 at 1:41 PM, Bozhidar Batsov
|
I'm an idiot. This has nothing to do with the Emacs Lisp encoding implementation - after all this is the response we were receiving for decoding from nREPL server. :-) The message was incomplete, causing the decode error. This was fixed in #616. |
CIDER 20140528.14
eval:
(.split "1,2,3" ",")
result (in messages buffer):
Error: (error "Unmatched bracket or quote")
The text was updated successfully, but these errors were encountered: