Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format-code op to call cljfmt with option #556

Merged

Conversation

liquidz
Copy link
Member

@liquidz liquidz commented Oct 24, 2018

Update format-code op to call cljfmt.core/reformat-string with config option.

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing
  • The new code is not generating reflection warnings
  • You've updated the README (if adding/changing middleware)

@bbatsov
Copy link
Member

bbatsov commented Oct 24, 2018

Great improvement!

You just need to also update the middleware descriptor (to reflect the extra param) and the changelog and we're good to merge this.

@liquidz liquidz force-pushed the feature/format-code-op-with-option branch from 66e2e92 to 5825d32 Compare October 24, 2018 11:39
@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #556 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   72.84%   72.99%   +0.15%     
==========================================
  Files          36       36              
  Lines        2397     2411      +14     
  Branches      141      141              
==========================================
+ Hits         1746     1760      +14     
  Misses        510      510              
  Partials      141      141
Impacted Files Coverage Δ
src/cider/nrepl/middleware/format.clj 97.22% <100%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06fd11d...5825d32. Read the comment docs.

@liquidz
Copy link
Member Author

liquidz commented Oct 24, 2018

@bbatsov I updated middleware descriptor and changelog.

@bbatsov bbatsov merged commit 904aef7 into clojure-emacs:master Oct 24, 2018
@bbatsov
Copy link
Member

bbatsov commented Oct 24, 2018

Great work! Thanks a lot! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants