Use a multimethod for content-type dispatching

[plexus]

Make the content-type middleware that handles inlining of File/URL/Image
extensible through a multimethod. This makes it possible for developers to add
handling of custom types.

Regular Clojure values can be given a :type metadata to make them
distinguishable. Other types can dispatch on the class.

• The commits are consistent with our contribution guidelines
• You've added tests to cover your change(s)
• All tests are passing
• The new code is not generating reflection warnings
• You've updated the README (if adding/changing middleware)

[plexus]

I want to see if I can get a few tests on this, but it might take me a few days.

[bbatsov]

The implementation looks good to me. You might mention something about this in the readme and the changelog.

[arrdem]

LGTM! Thanks for cleaning this up @plexus.

[plexus]

Thanks for looking at this. I'll be on the road a lot the coming week but I do plan to still add some stuff here so don't merge yet.

Note to self:

• README
• Changelog
• CI fails?
• Add tests

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@ca08ea4). Click here to learn what that means.
The diff coverage is 38.09%.

@@            Coverage Diff            @@
##             master     #548   +/-   ##
=========================================
  Coverage          ?   72.97%           
=========================================
  Files             ?       36           
  Lines             ?     2442           
  Branches          ?      142           
=========================================
  Hits              ?     1782           
  Misses            ?      518           
  Partials          ?      142

Impacted Files	Coverage Δ
src/cider/nrepl/middleware/content_type.clj	47.72% <38.09%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca08ea4...da53829. Read the comment docs.

[bbatsov]

@plexus I plan to cut 0.19 in the next few days. Let me know if you want me to merge this for it or not.

[plexus]

Not before CI is green. Bozhidar Batsov <[email protected]> 於 2018年12月21日 週五 17:03寫道：

…

@plexus <https://github.com/plexus> I plan to cut 0.19 in the next few days. Let me know if you want me to merge this for it or not. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#548 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAB91DWajA20lnAchOJJMlB29QVsUM54ks5u7QY0gaJpZM4XUlo5> .

[bbatsov]

One year later...

I think we've got a new CI and that's it's green! 😉

[plexus]

I swear I think about this PR at least once a month 🙃

[arrdem]

Careful, you're gonna make me dust off my Clojure setup just to free myself from the GH notifications ;)

[bbatsov]

@plexus This one needs to be rebased. Perhaps we will finally merge it this year! :D

[plexus]

The CI woes never end 🤣

Cloning git repository
Cloning into '.'...
Warning: Permanently added the ECDSA host key for IP address '140.82.114.4' to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

In any case, rebased, and adding a CHANGELOG entry and some info in the docs.

[bbatsov]

In any case, rebased, and adding a CHANGELOG entry and some info in the docs.

As for the CI - I like the idea of switching to GHA more and more each day. :D

[plexus]

Last used four weeks ago... did Circle forget our key?

[plexus]

Maybe it's to do with me pulling from my own repo? let me try to open a fresh PR.

[plexus]

Closing this in favor of #742