Include special forms in apropos

[xiongtx]

Fixes #409.

Some special forms (e.g. if) are included in apropos if the search-ns is nil or
clojure.core.

Included special forms are those those with documentation in clojure.repl,
as well as &, catch, and finally, the first of which uses the
documentation of fn and the others that of try.

Update:

With Lein 2.7.1, this passes:

$ lein with-profile +master,+test-clj test

Ran 181 tests containing 1118 assertions.
0 failures, 0 errors.

Whereas this does not:

$ lein with-profile +master,+plugin.mranderson/config,+test-clj test

Exception in thread "main" java.io.FileNotFoundException: Could not locate fipp/edn__init.class or fipp/edn.clj on classpath., compiling:(cider/nrepl/middleware/pprint.clj:1:1)
	at clojure.lang.Compiler.load(Compiler.java:7391)
...

Maybe the thomasa/mranderson plugin needs to be updated?

Before submitting a PR make sure the following things have been done:

• The commits are consistent with our contribution guidelines
• You've added tests to cover your change(s)
• All tests are passing
• The new code is not generating reflection warnings
• You've updated the readme (if adding/changing middleware)

Thanks!

[xiongtx]

@bbatsov Seems like some of the tests are not passing, which I suspect is due to thomasa/mranderson. Who can look more into this?

[bbatsov]

Probably @benedekfazekas

[benedekfazekas]

will have a look

[vspinu]

So all these functions conflate symbols and vars now?

If that's the way, then I think instead of inserting (special-symbol? ...) checks everywhere it's better to have all these internals in one place - (var-meta ..). Also IMO including one middleware into another is not ideal. All these small utilities could easily live in a separate utility namespace (precisely what has been done as an aside of #405 btw).

@xiongtx do you plan for more imediate changes? Could you please give me a day or so to merge #405 as any changes to info and apropos will likely introduce hard conflicts with that branch. Thanks.

[xiongtx]

info.clj already conflates symbols and vars. How would you separate them?

[vspinu]

Not sure. How and where is it conflating them?

I guess my point is that those small utility functions are useful outside of info.clj and better have precise semantics. So var-xyz better operate only on vars and not on anything else. But on the second though, (var-doc 'foo) could be defined as (:doc (:meta #'foo)) and not (:doc (:meta foo)). That would be quite consistent. Special symbols are not held in vars and cannot hold meta so there is probably no harm to treat them as pseudo vars.

[benedekfazekas]

had a quick look on the build failures. They don't seem to be mranderson problems. The fact that only some java/clojure version variations fail in the matrix in itself is a good indication that it is not the inlining where something goes wrong.

hope this makes sense