Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commitlog: Small tweaks #1978

Merged
merged 2 commits into from
Nov 11, 2024
Merged

commitlog: Small tweaks #1978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
182f9b8
commitlog: Export memory repo when test feature is enabled
kim Nov 11, 2024
3a087e3
commitlog: Constrain segment trait bounds
kim Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/commitlog/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ description = "Implementation of the SpacetimeDB commitlog."

[features]
default = ["serde"]
# Enable types + impls useful for testing
test = []

[dependencies]
bitflags.workspace = true
Expand Down
6 changes: 3 additions & 3 deletions crates/commitlog/src/repo/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ use crate::{
};

pub(crate) mod fs;
#[cfg(test)]
#[cfg(any(test, feature = "test"))]
pub mod mem;

pub use fs::Fs;
#[cfg(test)]
#[cfg(any(test, feature = "test"))]
pub use mem::Memory;

pub type TxOffset = u64;
Expand All @@ -28,7 +28,7 @@ pub type TxOffsetIndex = IndexFile<TxOffset>;
/// representation.
pub trait Repo: Clone {
/// The type of log segments managed by this repo, which must behave like a file.
type Segment: io::Read + io::Write + FileLike + io::Seek;
type Segment: io::Read + io::Write + FileLike + io::Seek + Send + Sync + 'static;

/// Create a new segment with the minimum transaction offset `offset`.
///
Expand Down
Loading