Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI - Remove unused default_identity stuff #1969

Merged
merged 2 commits into from
Nov 9, 2024
Merged

CLI - Remove unused default_identity stuff #1969

merged 2 commits into from
Nov 9, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Nov 8, 2024

Description of Changes

I removed the default_identity member and the associated functions, since they're not currently used anywhere.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

Existing tests only

@bfops bfops added release-any To be landed in any release window CLI only This change only affects the CLI behavior labels Nov 8, 2024
cloutiertyler
cloutiertyler approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfops bfops added this pull request to the merge queue Nov 9, 2024
Merged via the queue into master with commit 7f9903d Nov 9, 2024
8 checks passed
@Centril Centril deleted the bfops/remove-default-identity branch November 11, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloutiertyler cloutiertyler cloutiertyler approved these changes

Assignees
No one assigned
Labels
CLI only This change only affects the CLI behavior release-any To be landed in any release window
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfops @cloutiertyler