-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI - Login flow #1878
CLI - Login flow #1878
Conversation
IdentityConfig.token
…/cli-login' into bfops/cli-replace-token
…/cli-login' into bfops/cli-replace-token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Love the red. I left two small comments.
(Going to fix |
…r' into bfops/cli-replace-token
…r' into bfops/cli-replace-token
changes and review have happened
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I might want to bikeshed server-issued-login
before final 1.0 release, but it is more descriptive now already.
Description of Changes
Add the
spacetime login
command, which gets a login token from the web server.I have removed
IdentityConfig
in this PR, because we don't want to be storing identities anymore. I've also removed almost all of the--identity
CLI parameters, because we want users to be going throughspacetime login
to switch identities, rather than "just in time" via CLI params.Closes #1847.
API and ABI breaking changes
This breaks existing stored identities in the config file.
Expected complexity level and risk
3
Testing
spacetime login --host [web-host]
(a local one works fine)spacetime login --direct local
Future work
spacetimedb_token
should look to be backwards-compatible with the future changes (e.g. we may want to allow users tologin
to switch between multiple accounts - what will we cache and where?)spacetimedb_token
out of config so we're no longer storing sensitive tokens in a human-edited file